fix: active board doesn't always load #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #29 where if the active board is not the first board, the board doesn't scroll into view and the trackables do not appear. It also prevents the active board from being reset to the first board all the time on page load.
donalmacanri
force-pushed
the
29-fix-active-board-initial-load
branch
from
f1fca7d
to
784f6a5
Compare
✅ Deploy Preview for nomie6-oss ready!
|
RdeLange
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #29 (also mentioned in #25) where if the active board is not the first board, the board doesn't scroll into view and the trackables do not appear.
It also addresses another behaviour where the active board is reset to the first board on page load (a side effect of the on:index event when the swiper initially loads).