Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move checkpoint funtions from runner to a new sub-package #1495

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Feb 18, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers. By the way, if you're not familiar with how to use pre-commit to fix lint issues or add unit tests, please refer to Contributing to OpenMMLab.

Motivation

Move checkpoint relative functions from mmengine/runner/checkpoint to mmengine/checkpoint to make structure clear and to avoid circle import.

Modification

  • Move mmengine/runner/checkpoint to mmengine/checkpoint
  • Import from mmengine/checkpoint rather than mmengine/runner/checkpoint

BC-breaking (Optional)

No

TODO

[ ] FlexibleRunner (DDP, DeepSpeed, ColossalAI)
[ ] Runner
[ ] Load checkpoint
[ ] Resume

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMPretrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhouzaida zhouzaida marked this pull request as draft February 18, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant