Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add externalHost support for postgres, redis and vespa #3490

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Faylixe
Copy link

@Faylixe Faylixe commented Dec 17, 2024

Description

The Helm chart design actually partially support usage of external component, especially for storage. Indeed, support for Postgres, Redis, and Vespa dependencies allow enabled flag to prevent from deploying such solutions, but external host configuration is not permitted as it is injected into the chart configmap without any possibilities of tuning.

This PR proposes to add the following custom values:

postgres:
    externalHost: ""

redis:
    externalHost: ""

vespa:
    externalHost: ""

And associated template helpers that would decide which host to use in the ConfigMap (created resources if enabled, externalHost otherwise).

How Has This Been Tested?

I will test it by deploying the Helm chart locally in both variations: with and without storage components enabled to ensure it works as expected.

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Dec 17, 2024

@Faylixe is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

@Faylixe Faylixe marked this pull request as ready for review December 17, 2024 15:06
@Faylixe
Copy link
Author

Faylixe commented Dec 17, 2024

Since I didn't find any guideline regarding Helm formatting I just adapted my code to the current Helm chart style. Please let me know if there is any additional process / guideline to follow for the chart :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant