-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle game chats and write them into the log #421
Conversation
I'm not entirely confident that it wouldn't be a better idea to still try to just Also, should this be optional? |
Oof, I've messed something up and it doesn't pick up chats during the game, will check later. |
Ought to be fixed. I'm running it on my bots now and they log when I chat with them during or after a game. |
if (line.username === config.username) { | ||
return; | ||
} | ||
if (line.date < cutoff_timestamp) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dunno if it's worth noting that converting new Date()
to a number gives you epoch time and line.date
is also epoch time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you felt like asking, I'm happy to add a note!
src/Game.ts
Outdated
}); | ||
} | ||
|
||
trace.log("connecting"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably remove this or mention what game we're connecting for if you keep it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, yes, this was a leftover from debugging, will remove!
Players sometimes say things in the game chat, which I would be interested in at least becoming aware of.
Players sometimes say things in the game chat, which I would be interested in at least becoming aware of.
This ought to address #258