Add '--rating-history-db' to save ratings in a DB #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `--rating-history-db` command-line option to save ratings in an sqlite3 database. This adds a method to InMemoryStorage to save the rating history. It takes a `category` string for future use with rating grids, where there's a different InMemoryStorage for each rating category, but for now only `OneGameAtATime` has been updated. An aborted implementation used a new storage type OnDiskStorage instead of InMemoryStorage, but it was way too slow to build the table incrementally. Instead, this implementation writes the values in bulk at the end, using a generator expression to visit the rating history.
|
Revisiting this - did you have other purposes for this other than the experiment to infer starting ranks? Happy to merge if so, but for that experiment the thing that catches my eye with this is that we're storing the end ratings instead of what they were when they started, for example what their rating was after say 10 games or whatever. If it was just for the experiment, maybe we just close it out, I think we got what we needed already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--rating-history-dbcommand-line option to save ratings in an sqlite3 database.This adds a method to InMemoryStorage to save the rating history. It takes a
categorystring for future use with rating grids, where there's a different InMemoryStorage for each rating category, but for now onlyOneGameAtATimehas been updated.An aborted implementation used a new storage type OnDiskStorage instead of InMemoryStorage, but it was way too slow to build the table incrementally. Instead, this implementation writes the values in bulk at the end, using a generator expression to visit the rating history.