Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 Upgrade to react-native 0.76 and expo 52 #286

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

🚧 Upgrade to react-native 0.76 and expo 52 #286

wants to merge 15 commits into from

Conversation

zetavg
Copy link
Collaborator

@zetavg zetavg commented Dec 9, 2024 •
edited
Loading

Based on #283 - should merge that first.

  • VxRN
  • One
  • Tamagui
  • react-navigation - upgrading to v7
    • Proper migration to v7 Proper fix of route being immutable (aeab65a)
  • react-native-reanimated support
  • react-native-gesture-handler support
  • Support codegen in other packages and user code
  • Fix react-native-svg (might be related to codegen)
  • Revisit workarounds
    • Mocked LoadingView in packages/vite-native-hmr/src/hmr-client.ts

Manual Testing

  • iOS dev
    • examples/one-recommended
      • Component HMR (FeedCard)
      • Route HMR (profile, modify head YStack height)
  • iOS build
    • examples/one-recommended
  • Android dev
    • examples/one-recommended
      • Component HMR (FeedCard)
      • Route HMR (profile, modify head YStack height)
  • Android build
    • examples/one-recommended
  • Web dev
    • apps/onestack.dev
    • examples/one-recommended
  • Web build & serve
    • apps/onestack.dev
    • examples/one-recommended

Known Issues

  • Dev server might terminate unexpectally if a native app disconnects

More

@railway-app Railway App
Copy link

railway-app bot commented Dec 9, 2024

This PR was not deployed automatically as @zetavg does not have access to the Railway project.

In order to get automatic PR deploys, please add @zetavg to your team on Railway.

zetavg and others added 13 commits December 20, 2024 22:23
@zetavg
upgrade packages for RN 0.76 and expo 52
ae7c4e5
@zetavg
fix: react-native depends on @react-native-community/cli for cli comm…
3f71163 
…ands
@zetavg
fix: "Codegen didn't run for DebuggingOverlay" (and other RN internal…
d0e8e07 
… components)
@zetavg
define process and EXPO_OS for Expo to work properly
633a0a0
@zetavg
fix: HMRClient.unstable_notifyFuseboxConsoleEnabled is not a function…
c4ab3dd 
… (it is undefined)
@zetavg
workaround(RN): mock loading view
fd9fd4e
@zetavg
fix: make the custom build command work with new react-native version
d4d93fa
@zetavg
fix: ios native release build
2846537
@natew @zetavg
make things work with React Navigation 7
516002d
@zetavg
fix: inferred type of 'Tabs' cannot be named without a reference
52401a2 
Full error:

packages/one/src/layouts/Tabs.tsx (17,14): The inferred type of 'Tabs' cannot be named without a reference to '../../../../node_modules/@react-navigation/bottom-tabs/lib/typescript/module/src/types'. This is likely not portable. A type annotation is necessary.
@zetavg
fix types
0d0356e 
errors:

Types of property 'onPressIn' are incompatible.
  Type '((event: GestureResponderEvent) => void) | null | undefined' is not assignable to type '((event: GestureResponderEvent) => void) | undefined'.
      Type 'null' is not assignable to type '((event: GestureResponderEvent) => void) | undefined'.

…and other similar ones.
@zetavg
fix: not-found and sitemap routes should not be shown in the tab bar
cfd06af
@zetavg
fix: expo-modules-core/build/createWebModule has been removed
561f7f8 
Ref: expo/expo#29870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zetavg @natew