Testflight updates

[natew]

seeing an error on yarn dev where bottom-tabs tries to improt react-native/dist path and its not happy, and my resolveId isnt picking it up.

[railway-app]

🚅 Deployed to the pr-08c771-204 environment in onestack.dev

Service	Status	Web	Updated (UTC)
one	❌ Build Failed (View Logs)	Web	Dec 16, 2024 at 10:28 pm

[zetavg]

Hmm yea getting errors on dev server startup:

✘ [ERROR] Could not read from file: /Users/z/Projects/vxrn/apps/testflight/node_modules/react-native-web/dist/cjs/index.js/Libraries/Utilities/codegenNativeComponent

    node_modules/react-native-bottom-tabs/lib/module/TabViewNativeComponent.js:3:35:
      3 │ ...ponent from 'react-native/Libraries/Utilities/codegenNativeComponent';
        ╵                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[ 'command', 'errors', 'key', 'metafile', 'warnings' ]

 ERROR  Build failed with 1 error:                                     3:53:03 AM
node_modules/react-native-bottom-tabs/lib/module/TabViewNativeComponent.js:3:35: ERROR: Could not read from file: /Users/z/Projects/vxrn/apps/testflight/node_modules/react-native-web/dist/cjs/index.js/Libraries/Utilities/codegenNativeComponent

  node_modules/react-native-bottom-tabs/lib/module/TabViewNativeComponent.js:3:35: ERROR: Could not read from file: node_modules/react-native-web/dist/cjs/index.js/Libraries/Utilities/codegenNativeComponent
  at failureErrorWithLog (/Users/z/Projects/vxrn/node_modules/vite/node_modules/esbuild/lib/main.js:1473:15)
  at /Users/z/Projects/vxrn/node_modules/vite/node_modules/esbuild/lib/main.js:946:25
  at /Users/z/Projects/vxrn/node_modules/vite/node_modules/esbuild/lib/main.js:1354:9
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)



 ERROR  Build failed with 1 error:                                     3:53:04 AM
node_modules/react-native-bottom-tabs/lib/module/TabViewNativeComponent.js:3:35: ERROR: Could not read from file: /Users/z/Projects/vxrn/apps/testflight/node_modules/react-native-web/dist/cjs/index.js/Libraries/Utilities/codegenNativeComponent

[okwasniewski]

Small nit: you should import navigation options from native bottom tabs

[okwasniewski]

Let me know what I can do to fix this in the library, looking forward to get this working for you guys

[natew]

@okwasniewski thanks, yea this is something we need to fix i believe, we do handle these internal imports, but for some reason this one isn't, i'll poke at it more soon. Typically on RNW we just map it to an empty file or something, I do that in tamagui, so have an idea of what to try.

[natew]

got this mostly working, there's a bug with the tabs not stretching across anymore just need to see whats going on there

[hridoy43]

I am also getting this error when setting up dev server using yarn dev

yarn run v1.22.22
warning ../../../../package.json: No license field
$ one dev

    ➡ [tamagui] built config and components (112ms)
[vite] connected.
Cannot optimize dependency: moti/author, present in ssr 'optimizeDeps.include'
Cannot optimize dependency: @expo/cli, present in ssr 'optimizeDeps.include'
✘ [ERROR] Could not read from file: /Users/hridoy/projects/mine/matria/matria/node_modules/react-native-web/dist/cjs/index.js/Libraries/Utilities/codegenNativeComponent

    node_modules/react-native-svg/lib/module/fabric/DefsNativeComponent.js:1:35:
      1 │ import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';
        ╵                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] Could not read from file: /Users/hridoy/projects/mine/matria/matria/node_modules/react-native-web/dist/cjs/index.js/Libraries/Utilities/codegenNativeCommands

    node_modules/@react-navigation/bottom-tabs/node_modules/react-native-screens/lib/module/fabric/SearchBarNativeComponent.js:3:34:
      3 │ import codegenNativeCommands from 'react-native/Libraries/Utilities/codegenNativeCommands';
        ╵                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Build failed with 2 errors:
node_modules/@react-navigation/bottom-tabs/node_modules/react-native-screens/lib/module/fabric/SearchBarNativeComponent.js:3:34: ERROR: Could not read from file: /Users/hridoy/projects/mine/matria/matria/node_modules/react-native-web/dist/cjs/index.js/Libraries/Utilities/codegenNativeCommands
node_modules/react-native-svg/lib/module/fabric/DefsNativeComponent.js:1:35: ERROR: Could not read from file: /Users/hridoy/projects/mine/matria/matria/node_modules/react-native-web/dist/cjs/index.js/Libraries/Utilities/codegenNativeComponent

[zetavg]

Hi @hridoy43, this might be able to resolve that build failed issue: #195 (comment)

[okwasniewski]

got this mostly working, there's a bug with the tabs not stretching across anymore just need to see whats going on there

Can you try with latest release? It should be fixed