Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: substitute UT_ASSERTs with asserts from GTEST part 5 #744

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix: substitute UT_ASSERTs with asserts from GTEST part 5 #744

merged 2 commits into from
Oct 16, 2024

Conversation

EuphoricThinking
Copy link
Contributor

The PR is a part of a major fix, which will be provided in multiple files.

Ref. #569

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@EuphoricThinking EuphoricThinking requested a review from a team as a code owner September 19, 2024 15:37
@bratpiorka bratpiorka requested a review from lplewa October 7, 2024 09:24
@EuphoricThinking EuphoricThinking force-pushed the assertspr9 branch 2 times, most recently from 46ebf98 to cfae5c5 Compare October 7, 2024 14:58
lplewa
lplewa requested changes Oct 7, 2024
View reviewed changes
test/provider_os_memory_multiple_numa_nodes.cpp Outdated Show resolved Hide resolved
test/provider_os_memory_multiple_numa_nodes.cpp Outdated Show resolved Hide resolved
@EuphoricThinking
fix: segfault in src/memory_provider.c
12a2b86
@EuphoricThinking
fix: replace UT_ASSERTs with GTEST asserts
ced30bb 
    If possible, change non-void functions to void by passing pointers
    Otherwise, introduce error-indicating return values

    Ref. oneapi-src#569
@lplewa lplewa merged commit 112802c into oneapi-src:main Oct 16, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

@lplewa lplewa lplewa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EuphoricThinking @lplewa @lukaszstolarczuk