Move common functions to utils common #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Move_common_functions_to_utils_common
branch
2 times, most recently
from
de304ff
to
7b13504
Compare
|
Can you please move last commit to separate Pr (this with util to utils) |
ldorau
force-pushed
the
Move_common_functions_to_utils_common
branch
from
7b13504
to
37a0f0a
Compare
Done. (new PR: #731) |
ldorau
force-pushed
the
Move_common_functions_to_utils_common
branch
3 times, most recently
from
d9d1b6c
to
55bb643
Compare
PatKamin
approved these changes
Sep 19, 2024
ldorau
force-pushed
the
Move_common_functions_to_utils_common
branch
5 times, most recently
from
fcd4b2f
to
bcd50fb
Compare
Move all common functions to utils_common and rename them to utils_* Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Move_common_functions_to_utils_common
branch
from
bcd50fb
to
b1e1edb
Compare
bratpiorka
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move common functions to
utils_commonand rename them toutils_*.Checklist