fix: substitute UT_ASSERTs with asserts from GTEST part 4 #704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a part of a major fix, which will be provided in multiple files.
Ref. #569
Although canQuery*(...) use UT_ASSERTs only in their body and the returned value is interpreted as a reason to skip tests, not to fail, I assume that unsuccessful results from hwloc functions are fatal in order not to change canQuery*(...) return types. If this is not a plausible argument, I think of implementing an enum {SUCCESS, NOT_FATAL, FATAL} for deciding whether tests should fail or should be skipped.
The condition using ::memspaceGetTest::IsSkipped() in memspaceProviderTest is replaced due to its ineffectiveness: it has used the method from superclass for itself, before skipping any tests.
Introduced GTEST_OUT_* macros for logging error messages without interrupting the program execution and assessing the value of the given condition (maybe there could be something more elegant than a multi-functional macro). EXPECT_* and ADD_FAILURE() interefere with GTEST_SKIP() when used in a non-void helper function - tests are run in spite of labelling as ,,skipped" by the fixture.
Description
Checklist