Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: pool memory resource that can be used with an upstream memory resource #57

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igchor
Copy link
Member

@igchor igchor commented Dec 5, 2023

No description provided.

@vinser52
Copy link
Contributor

vinser52 commented Dec 5, 2023

Some general question:
On the last WG meeting we agreed that we do not need to implement memory resources on top of UMF (at least not now), correct? Instead we are discussing to have memory resource implementation on top of SYCL.
So why do we need this PR? Why not to focus on the items we agreed to implement for the next release?

@igchor
Copy link
Member Author

igchor commented Dec 5, 2023

@vinser52 that's correct, I just want to have something I can use for benchmarking/testing once we have the SYCL provider and different pool implementations (jemalloc). This PR just exposes some simple abstractions to build a pool memory_resource. I don't plan to have it merged for now. Would you prefer if I just kept it on a separate branch and not have the PR open?

@vinser52
Copy link
Contributor

vinser52 commented Dec 6, 2023

Thank you for your clarifications.

Would you prefer if I just kept it on a separate branch and not have the PR open?

Keeping it in a separate fork is OK. Regarding the branch instead of the fork do you mean creating a separate branch in this repo? Regarding PR, what is your intention by opening the PR? If you need a review than it totally makes sense and we can keep this PR and review/discuss the code.

@igchor
Copy link
Member Author

igchor commented Dec 6, 2023

My intention was just to have this visible so I can reference this PR when discussing the SYCL provider, show some examples, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants