github: automation: fixed rules for commit scope check #2286
+17
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjoursler
reviewed
Dec 18, 2024
| @@ -79,7 +67,7 @@ def main(): | |||
| is_ok = is_ok and result | |||
|
|
|||
| if is_ok: | |||
There was a problem hiding this comment.
Casually switching to snake_case halfway through the file that started with camelCase..
There was a problem hiding this comment.
Looks like argparse package has set the tone for main()...
|
This means that e.g. |
vpirogov
force-pushed
the
vpirogov/checker-fix
branch
from
1a93cc3 to
6a82eeb
Compare
rjoursler
approved these changes
Dec 18, 2024
vpirogov
force-pushed
the
vpirogov/checker-fix
branch
from
6a82eeb to
bceedb3
Compare
No, this one will fails because of capital 'R' :). Anything that follows the format of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates commit checker to avoid false positives in #2279 (job link), #2276, and #2272.
As
:can be used in commit message itself there's no good way to reliably identify cases with multi-level scope.