-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu: softmax: enable relaxed acc_mode (fixes MFDNN-12822) #2271
Open
dzarukin
wants to merge
2
commits into
main
Choose a base branch
from
dzarukin/bf16_softmax
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+96
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc
platform:cpu-x64
Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
labels
Dec 13, 2024
make test |
densamoilov
approved these changes
Dec 14, 2024
Hi @ranukund, could you, please, review the change? Thanks. |
ranukund
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few comments. Please incorporate as you see fit. Thanks!
dzarukin
force-pushed
the
dzarukin/bf16_softmax
branch
from
December 17, 2024 23:50
e03d3a8
to
f58c1e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:tests
documentation
A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc
platform:cpu-x64
Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MFDNN-12822
Fixes #2237
Numbers are obtained not from the perf machine but the trend is visible: