Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu: softmax: enable relaxed acc_mode (fixes MFDNN-12822) #2271

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dzarukin
Copy link
Contributor

@dzarukin dzarukin commented Dec 13, 2024

Fixes MFDNN-12822
Fixes #2237

Numbers are obtained not from the perf machine but the trend is visible:

perf,cpu,jit:avx10_1_512,,--mode=P --softmax --dir=FWD_I --sdt=bf16 --ddt=bf16 --stag=abcd --dtag=abcd --axis=3 --attr-acc-mode=relaxed 64x16x100x100,0,0.270752,0.192383,0,0.20202,0
perf,cpu,jit:avx10_1_512,,--mode=P --softmax --dir=FWD_I --sdt=bf16 --ddt=bf16 --stag=abcd --dtag=abcd --axis=3 64x16x100x100,0,0.208252,1.38135,0,1.44547,0

@dzarukin dzarukin requested review from a team as code owners December 13, 2024 21:53
@github-actions github-actions bot added documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 labels Dec 13, 2024
@dzarukin
Copy link
Contributor Author

make test
disable benchdnn_all
enable benchdnn_softmax
enable benchdnn_nightly

@dzarukin
Copy link
Contributor Author

Hi @ranukund, could you, please, review the change? Thanks.

Copy link
Contributor

@ranukund ranukund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments. Please incorporate as you see fit. Thanks!

doc/primitives/softmax.md Outdated Show resolved Hide resolved
doc/primitives/softmax.md Outdated Show resolved Hide resolved
doc/primitives/softmax.md Outdated Show resolved Hide resolved
doc/primitives/softmax.md Outdated Show resolved Hide resolved
doc/primitives/softmax.md Outdated Show resolved Hide resolved
doc/primitives/softmax.md Outdated Show resolved Hide resolved
doc/primitives/softmax.md Outdated Show resolved Hide resolved
doc/primitives/softmax.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tests documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BF16 Softmax on EMR got 40% performance regression
3 participants