[GPU] Fp8 compute backports #2266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kealan-barbieri
added
platform:gpu-intel
atkassen
approved these changes
Dec 13, 2024
hidefromkgb
approved these changes
Dec 13, 2024
dzarukin
reviewed
Dec 13, 2024
| && utils::one_of(mask_wei, 0, with_groups ? 3 : 1), | ||
| VCHECK_CONV_UNIMPL(utils::one_of(mask_wei, 0, with_groups ? 3 : 1) | ||
| && utils::one_of(mask_dst, 0, 2) | ||
| && utils::one_of(mask_src, 0, 3), |
There was a problem hiding this comment.
Could you, please, clarify why mask=3 for src but mask=2 for dst?
| | smask_t::zero_points_runtime_data_type | ||
| | smask_t::scales_runtime_groups | ||
| | smask_t::scales_runtime_data_type; | ||
|
|
||
| if (engine->kind() == engine_kind::gpu) |
There was a problem hiding this comment.
The logic here and below seems duplicated. Could you, please, consolidate it?
| @@ -195,7 +207,13 @@ struct matmul_pd_t : public primitive_desc_t { | |||
| sc.group_dims_[0] == 1 | |||
| && K() % sc.group_dims_[1] == 0); | |||
| } else { | |||
| ok = ok && (mask == 0); | |||
| ok = ok | |||
There was a problem hiding this comment.
Here must be a check for fp8 versus classic quantization.
| @@ -185,7 +185,7 @@ struct base_cfg_t { | |||
| } | |||
| const int64_t safe_digits = get_safe_digits(); | |||
| const int64_t safe_n_acc = (1LL << safe_digits) / max_value; | |||
| return safe_n_acc; | |||
| return std::max((int64_t)1L, safe_n_acc); | |||
There was a problem hiding this comment.
Returning safe_n_acc = 0 is intentional here, it says that input values are not reasonable. When it happened it returned zero?
kealan-barbieri
force-pushed
the
kealanba/compute_backports
branch
from
ded32f2 to
8aa5c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of mixed fp8 support, additional scale support for compute primitivies.
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?