benchdnn: graph: use plain copy and paste for reorder if fail to create pd #2262
+38
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzt1997
force-pushed
the
zhitao/bdnn-fix-input-displace
branch
from
0230587 to
e5bd03c
Compare
|
make test |
rongzha1
reviewed
Dec 13, 2024
wzt1997
force-pushed
the
zhitao/bdnn-fix-input-displace
branch
2 times, most recently
from
807e034 to
9c5fc54
Compare
rongzha1
approved these changes
Dec 16, 2024
wzt1997
force-pushed
the
zhitao/bdnn-fix-input-displace
branch
from
9c5fc54 to
361f33c
Compare
dzarukin
reviewed
Dec 16, 2024
tests/benchdnn/dnnl_memory.cpp
Outdated
| }); | ||
| return OK; | ||
| } else | ||
| return FAIL; |
There was a problem hiding this comment.
Suggest to build the block like that:
while (!r_pd_) {
// Fallback to GPU reorder.
dnnl_status_t status = dnnl_reorder_primitive_desc_create(
&r_pd_, src.md_, src.engine(), dst.md_, dst.engine(), attr);
if (status != dnnl_success) break;
// code that executes pd (written below)
}
// Last resort: fallback to a plain copy for identical mds.
// new code goes here. If not identical, return FAIL.
Please add BENCHDNN_PRINT(2, "%s\n", "[REORDER] Fallback to plain copy."); when the fallback succeeded, to see what's going on.
wzt1997
force-pushed
the
zhitao/bdnn-fix-input-displace
branch
from
361f33c to
141de68
Compare
|
make test Lightweight_scans |
|
make test |
TaoLv
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the backend does not support int4->int4 reorder currently, we use direct if-else condition to check the unsupported case during input displacement currently. We'd better try with reorder first and use plain copy-and-paste instead if the attempt fails.