Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu: generic: add simple SYCL reduction implementation #2249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgeor255
Copy link
Contributor

Description

This PR adds a fallback simple reduction implementations for cases not covered by #2243.

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@sgeor255 sgeor255 requested review from a team as code owners December 11, 2024 16:41
@github-actions github-actions bot added the platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic label Dec 11, 2024
Copy link
Contributor

@ShanoToni ShanoToni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small notes/ideas.

src/gpu/generic/sycl/sycl_primitive_conf.hpp Show resolved Hide resolved
src/gpu/generic/sycl/simple_reduction.cpp Outdated Show resolved Hide resolved
@sgeor255 sgeor255 force-pushed the svet/simple-reduction-sycl branch from 6070545 to fc994fd Compare December 12, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants