Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: cmake: enabling frame pointers #2244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spalicki
Copy link
Contributor

@spalicki spalicki commented Dec 7, 2024

Adding flags that build oneDNN with frame pointers, which can be used to walk CPU stack frames by profilers. First step for #1232

@spalicki spalicki self-assigned this Dec 7, 2024
@spalicki spalicki force-pushed the spalicki/frame_pointers branch from 6e86e96 to 08119c8 Compare December 9, 2024 20:36
@spalicki spalicki marked this pull request as ready for review December 9, 2024 20:36
@spalicki spalicki requested a review from a team as a code owner December 9, 2024 20:36
@spalicki spalicki requested review from a team December 9, 2024 20:36
@spalicki
Copy link
Contributor Author

spalicki commented Dec 9, 2024

make test

@spalicki
Copy link
Contributor Author

spalicki commented Dec 10, 2024

@theComputeKid @Radu2k If you prefer, I can limit this feature to x64, but it should be beneficial for perf profiling on all architectures.

Copy link
Contributor

@Radu2k Radu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spalicki That looks good to me. Thanks!

cmake/platform.cmake Outdated Show resolved Hide resolved
@spalicki spalicki force-pushed the spalicki/frame_pointers branch from 08119c8 to ccbeccc Compare December 17, 2024 02:28
@spalicki
Copy link
Contributor Author

make test

@spalicki
Copy link
Contributor Author

make Lightweight_scans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants