generic: sycl: Inner Product FWD #2214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AD2605
changed the title
github-actions
bot
added
platform:gpu-nvidia
Rbiessy
reviewed
Nov 15, 2024
|
@AD2605 you should probably update https://github.com/oneapi-src/oneDNN/blob/main/src/gpu/generic/sycl/README.md to mention inner product is supported :) |
|
@sgeor255 , updated the documentation |
github-actions
bot
added
the
documentation
AD2605
force-pushed
the
atharva/inner_product_fwd
branch
from
3bd9d00 to
c5d66f1
Compare
sgeor255
approved these changes
Nov 26, 2024
AD2605
force-pushed
the
atharva/inner_product_fwd
branch
from
a3b91d6 to
9c63d68
Compare
|
@oneapi-src/onednn-arch @oneapi-src/onednn-doc gentle nudge for reviewing the PR |
ranukund
approved these changes
Nov 27, 2024
ranukund
reviewed
Nov 27, 2024
AD2605
force-pushed
the
atharva/inner_product_fwd
branch
from
5899fe4 to
6989cb2
Compare
Rbiessy
approved these changes
Dec 10, 2024
mgouicem
reviewed
Dec 10, 2024
Comment on lines
+52
to
+55
| && attr()->has_default_values(sm::scales_runtime | ||
| | sm::zero_points_runtime | sm::post_ops | ||
| | sm::dropout | sm::scales_runtime_data_type | ||
| | sm::zero_points_runtime_data_type) |
There was a problem hiding this comment.
why not defer attribute and datatype checking to init_matmul?
| | sm::zero_points_runtime_data_type) | ||
| && memory_desc_wrapper(src_md()).is_plain() | ||
| && memory_desc_wrapper(dst_md()) | ||
| .is_plain(); // Blocked memory formats are not supported |
There was a problem hiding this comment.
I think is_plain is not enough to flatten the dimensions.
Here you need to check:
- that strides are dense (see is_dense).
- that the order of flattened dimensions for src and weights match.
- there is a missing check for weights_md()
There was a problem hiding this comment.
That's a good point, thanks. I had to create a new PR (#2248) to address the comments as I don't have permissions to push to this one. I think we can close this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the forward pass of the inner product for the generic sycl backend with support for different post-ops and data types