Add CTS for Sysman DriverExtension API's #60
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related-To: VLCLJ-2237 Signed-off-by: Vishnu Khanth <[email protected]>
aviralni
reviewed
Jul 25, 2024
|
|
||
| ### zesDriverGetExtensionProperties | ||
|
|
||
| * `GivenValidDriverHandleWhileRetrievingExtensionPropertiesThenValidExtensionPropertiesIsReturned`: |
There was a problem hiding this comment.
Please share whether there is a plan to maintain this readme for every test that is going to be added.
There was a problem hiding this comment.
Not sure. Since there are only two tests, i added it. In some other test suites like device, it was added in this format.
| GivenValidDriverHandleWhileRetrievingExtensionFunctionAddressThenValidAddressIsReturned) { | ||
| zes_driver_handle_t driver = lzt::get_default_zes_driver(); | ||
| std::vector<const char *> ext_functions = { | ||
| "zesPowerSetLimitsExt", |
There was a problem hiding this comment.
These are extension functions which are already part of the header file.
The query for function address would be done for "Driver-experimental" APIs which are not yet part of the L0 spec and an application would like to use them.
There was a problem hiding this comment.
By referring the Core API, the extension API's are in both header and extension API's. we can have a look at it.
Related-To: VLCLJ-2237 Signed-off-by: Vishnu Khanth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-To: VLCLJ-2237