Accurately determine if the user's location is within the visible map region #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Get map bounds from mapView size 2. Implement better point-in-polygon checking algorithm
jasonrogena
suggested changes
Feb 14, 2018
| && positionInQuestion.getLatitude() >= latSouth | ||
| && positionInQuestion.getLongitude() <= lonEast | ||
| && positionInQuestion.getLongitude() >= lonWest); | ||
| public static boolean contains(Point[] bounds, Point needle) { |
There was a problem hiding this comment.
Why not use LatLngBounds.contains()? Less code to maintain.
There was a problem hiding this comment.
com.mapbox.mapboxsdk.geometry.LatLngBounds is also available, if you'd rather go the MapBox way.
There was a problem hiding this comment.
I would have to test this & read up on it
There was a problem hiding this comment.
Both contains method are the same and inaccurate. They are not comparable
jasonrogena
approved these changes
Feb 15, 2018
ekigamba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was achieved by:
Fixes #43