Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgumentParser check_config method and skip_check parameter renamed to validate and skip_validation #639

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mauvilsa
Copy link
Member

@mauvilsa mauvilsa commented Dec 3, 2024

Before submitting

  • Did you read the contributing guideline?
  • Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa changed the title ArgumentParser .check_config renamed to validate and skip_check parame… ArgumentParser check_config method and skip_check parameter renamed to validate and skip_validation Dec 3, 2024
@mauvilsa mauvilsa added the refactor Improvements to the quality of the code label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c934d25) to head (fd559f3).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #639   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         6509      6509           
=========================================
  Hits          6509      6509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ter of ArgumentParser.{dump, save, get_defaults} renamed to skip_validation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements to the quality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant