Support referencing other schemas that have no output file.

cmd/gojsonschema/main.go

@@ -65,8 +65,6 @@ var rootCmd = &cobra.Command{
 			}
 			if s, ok := schemaOutputMap[id]; ok {
 				mapping.OutputName = s
-			} else {
-				mapping.OutputName = defaultOutput
 			}
 			if s, ok := schemaRootTypeMap[id]; ok {
 				mapping.RootType = s

pkg/generator/generate.go

@@ -43,12 +43,17 @@ func New(config Config) (*Generator, error) {
 		config:                config,
 		outputs:               map[string]*output{},
 		schemaCacheByFileName: map[string]*schemas.Schema{},
+		inScope:               map[qualifiedDefinition]struct{}{},
+		warner:                config.Warner,
 	}, nil
 }
 
 func (g *Generator) Sources() map[string][]byte {
 	sources := make(map[string]*strings.Builder, len(g.outputs))
 	for _, output := range g.outputs {
+		if output.file.FileName == "" {
+			continue
+		}
 		emitter := codegen.NewEmitter(80)
 		output.file.Generate(emitter)
 
@@ -155,9 +160,6 @@ func (g *Generator) findOutputFileForSchemaID(id string) (*output, error) {
 func (g *Generator) beginOutput(
 	id string,
 	outputName, packageName string) (*output, error) {
-	if outputName == "" {
-		return nil, fmt.Errorf("unable to map schema URI %q to a file name", id)
-	}
 	if packageName == "" {
 		return nil, fmt.Errorf("unable to map schema URI %q to a Go package name", id)
 	}

tests/data/crossPackageNoOutput/other.json

@@ -0,0 +1,14 @@
+{
+  "$schema": "http://json-schema.org/draft-04/schema#",
+  "id": "https://example.com/other",
+  "definitions": {
+    "Thing": {
+      "type": "object",
+      "properties": {
+        "s": {
+          "type": "string"
+        }
+      }
+    }
+  }
+}

tests/data/crossPackageNoOutput/schema.go.output

@@ -0,0 +1,18 @@
+// THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT.
+
+package schema
+
+import other "github.com/example/other"
+
+type Thing struct {
+	// S corresponds to the JSON schema field "s".
+	S *string `json:"s,omitempty"`
+}
+
+type Schema struct {
+	// DefInOtherSchema corresponds to the JSON schema field "defInOtherSchema".
+	DefInOtherSchema *other.Thing `json:"defInOtherSchema,omitempty"`
+
+	// DefInSameSchema corresponds to the JSON schema field "defInSameSchema".
+	DefInSameSchema *Thing `json:"defInSameSchema,omitempty"`
+}

tests/data/crossPackageNoOutput/schema.json

@@ -0,0 +1,23 @@
+{
+  "$schema": "http://json-schema.org/draft-04/schema#",
+  "id": "https://example.com/schema",
+  "type": "object",
+  "properties": {
+    "defInSameSchema": {
+      "$ref": "#/Definitions/Thing"
+    },
+    "defInOtherSchema": {
+      "$ref": "other.json#/Definitions/Thing"
+    }
+  },
+  "definitions": {
+    "Thing": {
+      "type": "object",
+      "properties": {
+        "s": {
+          "type": "string"
+        }
+      }
+    }
+  }
+}

tests/integration_test.go

@@ -51,6 +51,22 @@ func TestCrossPackage(t *testing.T) {
 	testExampleFile(t, cfg, "./data/crossPackage/schema.json")
 }
 
+func TestCrossPackageNoOutput(t *testing.T) {
+	cfg := basicConfig
+	cfg.SchemaMappings = []generator.SchemaMapping{
+		{
+			SchemaID:    "https://example.com/schema",
+			PackageName: "github.com/example/schema",
+			OutputName:  "schema.go",
+		},
+		{
+			SchemaID:    "https://example.com/other",
+			PackageName: "github.com/example/other",
+		},
+	}
+	testExampleFile(t, cfg, "./data/crossPackageNoOutput/schema.json")
+}
+
 func TestCapitalization(t *testing.T) {
 	cfg := basicConfig
 	cfg.Capitalizations = []string{"ID", "URL", "HtMl"}