Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 8 and rewrite Developer Excuse to local file instead of API #49

Conversation

omgitsjan
Copy link
Owner

This pull request includes two significant changes to our application. Firstly, we've updated our project to use the latest .NET 8 framework, bringing improved performance, enhanced features, and better security. Secondly, we've refactored the Developer Excuse feature, transitioning from relying on an external API to using a local file. This shift enhances our application's reliability and reduces external dependencies.

Key Changes

  1. Update to .NET 8:

    • The entire project has been upgraded to .NET 8.
    • Necessary adjustments have been made to ensure compatibility with the new framework version.
    • This update paves the way for utilizing the latest .NET features and optimizations.
  2. Developer Excuse Refactor:

    • Removed dependency on the external Developer Excuse API.
    • Implemented a local JSON file-based approach for storing and retrieving developer excuses.
    • The feature now reads excuses from excuses.json located in the Data directory, offering quicker access and easier management.
    • Adapted relevant service and tests to align with this new approach.

Benefits

  • Upgrading to .NET 8 aligns us with the latest standards and features offered by the .NET ecosystem.
  • Local handling of developer excuses improves the feature's speed and reliability as it no longer depends on external API availability.
  • This transition also offers more straightforward management and customization of the excuses list.

Testing and Verification

  • Extensive testing has been conducted to ensure the application's functionality remains intact post .NET upgrade.
  • New unit tests have been added to verify the local file-based Developer Excuse feature, focusing on its ability to handle various scenarios such as empty or invalid JSON files.

This update marks a significant step towards modernizing our application and optimizing its features. Your review and feedback on these changes are highly appreciated.

@omgitsjan omgitsjan added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file labels Jan 7, 2024
@omgitsjan omgitsjan added this to the Feature Set Completion milestone Jan 7, 2024
@omgitsjan omgitsjan self-assigned this Jan 7, 2024
@omgitsjan omgitsjan merged commit 73e1caf into master Jan 7, 2024
3 checks passed
@omgitsjan omgitsjan deleted the 21-bugfeature-developer-excuses-not-working-and-returns-error-code-0-error-while-copying-content-to-a-stream branch January 7, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG/FEATURE] Developer Excuses not working and returns Error Code 0 (Error while copying content to a stream)
1 participant