Remove webgateway cache #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
will-moore
reviewed
Apr 15, 2024
| webgateway_tempfile.abort(fpath) | ||
| raise Http404 | ||
| webgateway_cache.setOmeTiffImage(request, server_id, imgs[0], tiff_data) | ||
| webgateway_tempfile.abort(fpath) |
There was a problem hiding this comment.
not sure that this line does anything now?
There was a problem hiding this comment.
Ah - I missed the unchanged fpath, rpath, fobj = webgateway_tempfile.new(...) above, which makes more sense and explains .abort()
|
Good to clean up this unused code. Changes look good. |
sbesson
reviewed
Apr 17, 2024
will-moore
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the webgateway cache functionality for rendered images and refactors the
tempfilefunctionality into its own new file.The motivation behind removing the webgateway cache is the minimal performance improvements from having the cache versus the large overhead introduced with the required cache invalidation. Tasks like applying rendering settings to a large number of images takes much longer than needed due to cache invalidation.