Handle sudo connection in the account view #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand webadmin.views.my_account to also detect whether the current context was created via sudo If the current session was created with sudo, disable the ability to update experimenter properties and password in the UI
will-moore
approved these changes
Nov 29, 2023
knabar
reviewed
Nov 30, 2023
There was a problem hiding this comment.
I feel we need to go a small step further; having an editable form without a "Save" button seems confusing.
Some options, not necessarily better:
- disable (instead of remove) the "Save" button
- add some explanatory text on why there is no "Save" button
- Make the form inactive (e.g. by adding the
inertproperty, see https://stackoverflow.com/a/73500364/34171)
knabar
approved these changes
Dec 12, 2023
|
Thanks @knabar, the approach of the last commit makes sense to me. Passing back to @will-moore and @pwalczysko for another round of review. |
|
Looks good - form is "inert":
|
|
confirming, lgtm |
pwalczysko
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445
Summary of changes
To test this PR, follow the authentication workflow described in #445 (comment) i.e.
--sudovia the CLIUser settingsWithout this PR, the
SaveandChange my passwordbutton should be active. Clicking onSaveshould launch the 500 error page with a serverSecurityViolationof typeCurrent user is not admin for the given user(s). Clicking onChange my passwordwill ask for the current user password which is not known in this workflow since the session was created using the principal password.With this PR, both buttons should be hidden.