Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ?show=fileset-123 #514

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

will-moore
Copy link
Member

Often it's useful to find Images etc by Fileset, e.g. when an import completes with...

...
Other imported objects:
Fileset:6314846

==> Summary
444 files uploaded, 1 fileset created, 1 image imported, 0 errors in 0:13:35.110

This PR adds support for webclient/?show=fileset-6314846. Since we can't select a Fileset in the webclient, we simply pick a Image from that Fileset, similar to support for ?show=roi-123.

@knabar knabar added this to the 5.24.0 milestone Nov 17, 2023
@knabar
Copy link
Member

knabar commented Dec 12, 2023

@will-moore Works fine for me, but it does seem to pick the last (or a random?) image in the fileset; would it make sense to always select the first image (presumably lowest ID)?

@will-moore
Copy link
Member Author

Thanks @knabar - fixed now to pick the "first" image (lowest ID).

@knabar knabar merged commit 5ec437f into ome:master Dec 19, 2023
9 checks passed
Copy link
Member

@pwalczysko pwalczysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built the omero-web locally as our merge-ci is not available.
Indeed, when a second image in the fileset is selected, than a url like /myserlver/weblcient/?show=fileset-79 shows the first image in that fileset. Lgtm. Thanks @knabar for going ahead, just adding this for completeness sake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants