Merge pull request #541 from will-moore/fix_kwargs_overwrite_in_scrip…

…t_activities Don't overwrite kwargs in activities json
ome · Mar 12, 2024 · 99aebd2 · 99aebd2
2 parents 71372e9 + d99c184
commit 99aebd2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/omeroweb/webclient/views.py b/omeroweb/webclient/views.py
@@ -3851,16 +3851,16 @@ def activities(request, conn=None, **kwargs):
                     try:
                         # we can only retrieve this ONCE - must save results
                         results = proc.getResults(0, conn.SERVICE_OPTS)
-                        kwargs = {
+                        update_kwargs = {
                             "status": "finished",
                             "returncode": cb.returncode,
                         }
                         if cb.returncode != 0:
-                            kwargs["Message"] = (
+                            update_kwargs["Message"] = (
                                 f"Script exited with failure."
                                 f" (returncode={cb.returncode})"
                             )
-                        update_callback(request, cbString, **kwargs)
+                        update_callback(request, cbString, **update_kwargs)
                         new_results.append(cbString)
                     except Exception:
                         update_callback(