Enable public user

[dpwrussell]

Enables the public user if the same settings that are required for the web are specified to the server.

I gave some thought to making this non-public-user specific, but this did not make much sense to me given its limited capabilities. I believe for that to be useful it would be necessary to build something much more complicated that takes configurations of users, groups and user-group memberships.

Even for this simple case, if it was generic it would not be logical to me (imagining myself an end user) that the server docker would also take one username and one groupname and that the given username would be in the given group.

No problem if you don't want to merge this in favour of a more powerful mechanism for adding users and groups, thanks to the modularised run scripts I can provide this in my package instead easily until that exists.

Depends on #1 I will rebase as that is merged.

[manics]

I've checked the IDR where we've decoupled server and web, and omero.web.* properties are only needed in OMERO.web, they're not used by the server. On one hand using the properties CONFIG_omero_web_public_user and CONFIG_omero_web_public_password means you'll be able to use the same env-vars when running the server and web images, on the other it means you're setting unnecessary properties. Anyone else have thoughts?

[dpwrussell]

Yes, normally that is the case because web settings are only applicable to web, but as there is a server prerequisite explicitly for web in this case, it seemed to make sense to use the same setting key.

[manics]

@dpwrussell Could you rebase this please?

@openmicroscopy/devops How does everyone feel about auto-creating a public user if CONFIG_omero_web_public_enabled=true but no other params are passed? Do you think this should be part of the main omero-server image, or a separate omero-server-public image which we maintain?

[joshmoore]

I'm happy for public user config to be part "omero-server-docker 5.4" since that's currently recommended practice. It might be that with the true read-only work it'll look different in 5.5 or later, but so be it.

[dpwrussell]

Rebased and tested.

[joshmoore]

Note: currently looking at this.

[joshmoore]

Related: drop https://gitlab.com/openmicroscopy/incubator/docker-dev-compose/blob/0677a98ebf75a121c417e2b45478daaefa1d2e27/omero-server-public/docker-compose.yml#L40