Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests: clean up warnings #386

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Unit tests: clean up warnings #386

merged 2 commits into from
Nov 14, 2023

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Oct 30, 2023

Noticed while working on #385, the current unit tests throw a few warnings post-completion.
This should update the corresponding unit tests accordingly:

  • for session tests where existing clients are expected not to be re-usable (due to conflicting arguments), the existing client is cleared from the store to comply with the deletion semantics
  • table tests for column names throwing a tables.NonNaturalNameWarnings are now internally recording the warnings and testing them

CI tests should be unaffected but warnings should no longer be thrown after the tests report.

@sbesson
test_sess: clear client from mock store for conflicting sessions tests
a70f586 
Without this change the clients assert in the MyStore deletion method
would throw a warning at the end of the execution of the tests
@sbesson
test_hdfstorage: catch and test NonNaturalNameWarning thrown by PyTables
efdd174
@sbesson sbesson requested a review from jburel October 30, 2023 17:03
@sbesson sbesson changed the title Tests: remove warnings Unit tests: clean up warnings Oct 30, 2023
jburel
jburel approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@jburel jburel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
Everything is green

@jburel jburel merged commit 562edd2 into ome:master Nov 14, 2023
7 checks passed
@sbesson sbesson deleted the tests_warnings branch November 14, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jburel jburel jburel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbesson @jburel