Vite

[will-moore]

See testing sheet at https://docs.google.com/spreadsheets/d/17jQ1Hws42ob-2AYWaO7-272tKdXDacfdzZCk-xk62Z4/edit#gid=0

This is a major update of omero-figure to update all dependencies to their latest versions, including:

• jQuery
• Bootstrap UI framework - including all new bootstrap-icons
• Underscore
• Raphael
• remove jQueryUI and use native range inputs for sliders
• replace usage of grunt build workflow with https://vitejs.dev/ (don't need global install of grunt now)
• All JavaScript is now imported ES modules (no global variables etc).
• Underscore templates are now .template.html so they are recognised as raw strings by vite
• Colorpicker is removed (EOL) - use browser colorpicker instead
• ShapeEditor is now included in this repo.

Vite gives us a JS-based dev server during development (similar to iviewer).

New dev workflow - see README.

Testing:

Since this work impacts all of the JavaScript and html code, ALL that functionality will need testing:

• Every button, menu-option, dialog, form element etc needs to be checked.
• I don't know that we have testing scenarios for most of the app. Only for opening, saving figures.

[will-moore]

@Tom-TBT - I have added click-handling so the range sliders (channels and z-projection) should behave the same as the did before with jQuery sliders - The handle nearest to the point you clicked is moved to where you clicked.

[pwalczysko]

Sorry, deleted the comment which was reporting a bug of copy and paste of ROIs. This was caused by me using a smaller screenshot of the same image - in fact, the behaviour is as expected when pasting onto an image of the same size as was the intention.

[pwalczysko]

Firefox, Mac M1 - ^^^ these sliders look strange, the left-hand side min slider

[pwalczysko]

Please address the sliders issue in Preview panel. #477 (comment) and the spacing as per #477 (comment)

[pwalczysko]

Firefox, Mac, any image ^^^ Edit labels header is a bit squished into the box above it - this is different than without this PR, which is

Could a proper spacing be added ?

[will-moore]

@pwalczysko - thanks for the testing.

Slider handle positions (#477 (comment)) was actually caused by a different PR giving wrong values for min (-2147483648), so the slider minimum value was very low, causing the handles to overlap at the top. See ome/omero-web#536 (comment) (fixed now, but will need image panels to be removed or updated since they will still contain the wrong values).

The thick sliders in Firefox is fixed by b7cfdfa above and the Edit Labels spacing is also fixed now.

[pwalczysko]

fixed now, but will need image panels to be removed or updated since they will still contain the wrong values).

You mean panels in pre-existing figures ? i.e. when a figure was created on merge-ci after the ome/omero-web#536 was open, but before your fix ome/omero-web#536 (comment), then the panels contain wrong values, do i get it right ? Panels updated or created before or after this period should contain correct values ?

[pwalczysko]

The thick sliders in Firefox is fixed by b7cfdfa above and the Edit Labels spacing is also fixed now.

Confirming this fix.

Slider handle positions

Yes, these are fixed. Really not sure about the value remark #477 (comment)

[pwalczysko]

Please explain about #477 (comment). Thanks

[pwalczysko]

Really cannot say that this is caused by this PR, but on merge-ci (ie. not for example on outreach), when I open a Figure it opens in a new tab (expected). But, only on merge-ci, this new tab is not marked with the OMERO logo.

merge-ci (webclient tab leftmost, OMERO.figure tabs to the right of it)

outreach server (both webclient tab and figure tab to its right have OMERO logo):

Edit: iviewer displays the same behaviour ^^^, probably ignore.

[will-moore]

The favicon.ico is configured by the omero-web framework itself and not by the apps (iviewer/figure) at https://github.com/ome/omero-web/blob/02bd670ca7628ecb293108f394ef062a66a7beb4/omeroweb/settings.py#L867.
I'm not sure why it's not working on merge-ci but it's not related to this PR.

[will-moore]

Re: #477 (comment) - as discussed, you are correct that this was a temporary bug caused by ome/omero-web#536 and won't affect any users.

[pwalczysko]

Re: #477 (comment) - as discussed, you are correct that this was a temporary bug caused by ome/omero-web#536 and won't affect any users.

Understood, thank you.

[jburel]

Merging so we can move forward