Add documentation for ome/omero-py#418 #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Is it worth updating theomero.grid.Table method signatures in this page to mention the optional current keyword allowing to specify the Ice context as a dictionary?
For someone who has no experience with the tables API, this would make at least clarify where the omero.tables.include_row_numbers is expected to be passed.
As per https://github.com/ome/omero-py/pull/418/files, the readCoordinates API should also respect the inclusion flag and could also be annotated with a similar note.
|
As suggested, an example e.g. |
chris-allan
force-pushed
the
tables-row-numbers
branch
3 times, most recently
from
7ea9c5a
to
9e2600c
Compare
sbesson
reviewed
Jul 11, 2024
chris-allan
force-pushed
the
tables-row-numbers
branch
from
4cbf31a
to
906d1b5
Compare
sbesson
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for ome/omero-py#418