-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid hard-coded field-of-view path "0" #300
Conversation
Looks good, and works for me. Is this still a |
I still wanted to look into how to cover this by tests. Maybe by parametrizing |
I added a test. Since failed image lookups fail gracefully and return zeros, I had to change the image values of the test arrays to something non-zero. The alphanumeric test case failed on master and succeeds on this branch. |
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
4455b89
to
b48da21
Compare
Hi @aeisenbarth can you merge in origin/master which should fix the build failures above |
Fixes #248
The current code assumes image paths under a well always match field of view indices, especially that "0" exists. However, the NGFF spec allows alphanumeric paths.
This change looks up the actual image path from the first well. This should not have a performance impact since the first well's
.zattrs
is read anyways. It is still assumed all wells have the same first image path (which the previous code did as well). In that case, an array of zeros is read (as previously).