Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minimum fsspec version #295

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Set minimum fsspec version #295

merged 1 commit into from
Aug 7, 2023

Conversation

elyall
Copy link
Contributor

@elyall elyall commented Aug 2, 2023

Peg dependency fsspec's minimum version to 0.8.0 to address #294.

@elyall
Set minimum fsspec requirement
1dda3cf 
Peg minimum `fsspec` requirement to version `0.8.0`.
@elyall elyall changed the title Set minimum fsspec requirement Set minimum fsspec version Aug 2, 2023
will-moore
will-moore approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the demo test code with fsspec==0.7.4 reproduces the reported exception and updating to fsspec==0.8.0 fixes the issue.
Also, tests above are passing.

@will-moore will-moore merged commit 30f55fc into ome:master Aug 7, 2023
12 checks passed
@will-moore
Copy link
Member

Thanks for your contribution.

@elyall elyall deleted the patch-1 branch August 9, 2023 00:25
@will-moore will-moore added this to the 0.8.1 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-moore will-moore will-moore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@elyall @will-moore