Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-4: Axis Anatomical Orientation #253

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

thewtex
Copy link
Contributor

@thewtex thewtex commented Jul 27, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Jul 27, 2024

Automated Review URLs

@thewtex thewtex force-pushed the axis-anatomical-orientation branch 3 times, most recently from 247bf8b to 6aed27f Compare July 27, 2024 20:14
@thewtex thewtex changed the title WIP: RFC: Axis Anatomical Orientation RFC: Axis Anatomical Orientation Jul 27, 2024
@thewtex thewtex marked this pull request as ready for review July 27, 2024 20:14
@thewtex
Copy link
Contributor Author

thewtex commented Jul 27, 2024

@dyf @joshmoore please take a look 🙏

@thewtex thewtex force-pushed the axis-anatomical-orientation branch 2 times, most recently from c4e06c5 to f9fb9bf Compare July 27, 2024 20:34
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
@thewtex
Copy link
Contributor Author

thewtex commented Jul 28, 2024

@thewtex thewtex force-pushed the axis-anatomical-orientation branch 2 times, most recently from e0e569d to 7f9c4a7 Compare July 28, 2024 17:04
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Suggestions from other people seem helpful.

rfc/x/index.md Outdated Show resolved Hide resolved
rfc/x/index.md Outdated Show resolved Hide resolved
@joshmoore joshmoore mentioned this pull request Aug 30, 2024
Note: to produce the generated outputs locally:

1. Install `pixi` from https://pixi.sh
2. Run `pixi install`
3. Run `pixi run gen-all`
@thewtex
Copy link
Contributor Author

thewtex commented Sep 12, 2024

@lassoan @d-v-b @dzenanz thank you for the comments. Please submit future comments in a PR as described in the RFC process.

@joshmoore this draft ready to be integrated 🙏

@joshmoore
Copy link
Member

Now listed as RFC-4: https://ngff--253.org.readthedocs.build/rfc/4/index.html#rfc-4-axis-anatomical-orientation 🎉

If anyone would like to add an endorsement after this is merged, please add a comment here or feel free to open a PR against the index.md file.

@joshmoore joshmoore changed the title RFC: Axis Anatomical Orientation RFC-4: Axis Anatomical Orientation Sep 13, 2024
@joshmoore joshmoore merged commit 570e865 into ome:main Sep 13, 2024
9 checks passed
github-actions bot added a commit that referenced this pull request Sep 13, 2024
…orientation

RFC-4: Axis Anatomical Orientation

SHA: 570e865
Reason: push, by @joshmoore

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants