Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cap numpy to less than 2 #110

Closed
wants to merge 1 commit into from
Closed

Conversation

jburel
Copy link
Member

@jburel jburel commented Jun 17, 2024

@jburel jburel requested a review from joshmoore June 17, 2024 12:58
@joshmoore
Copy link
Member

👍 for the capping in general but it looks like something very odd is happening with the tests here:

          if path == "path_3d":
              assert 0 == metadata["channel_axis"]
  >           assert ["Red", "Green", "Blue"] == metadata["name"]
  E           AssertionError: assert ['Red', 'Green', 'Blue'] == '/'

@psobolewskiPhD
Copy link
Contributor

psobolewskiPhD commented Jun 19, 2024

The test fails seem to be the ones reported here:
#108

So related to ome_zarr_py version, this PR?
ome/ome-zarr-py#322
Actually, more likely ome/ome-zarr-py#342

@psobolewskiPhD
Copy link
Contributor

I think everything should be fine with numpy 2. Made PR to ome-zarr:
ome/ome-zarr-py#391
With latest 0.9.1dev0 ome-zarr the tests pass btw.

@joshmoore joshmoore closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants