Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZarrReader: Use chunk API #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ZarrReader: Use chunk API #20

wants to merge 1 commit into from

Conversation

dgault
Copy link
Member

@dgault dgault commented Mar 15, 2022

This is a followup to ome/bioformats#3794
I have commented out the override annotation and the use of the new FormatTools method for checking parameters. This should allow this PR to build and be included in the CI.

@joshmoore
Copy link
Member

Well this looks nice and simple...

@sbesson
Copy link
Member

sbesson commented Mar 23, 2022

While demoing OME-NGFF import into OMERO today in the merge CI server, I noticed that the pixel data was all 0 values. Using the latest CI server (i.e. without any open PRs) restored pixel data access so I wonder if this PR would be the cause for the issue?

@sbesson
Copy link
Member

sbesson commented Mar 24, 2022

--exclude to allow the review of #23 while @dgault is looking into the openBytes issue mentioned above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants