Merge branch 'recogito#185-restore-android-popup' into staging-merge-…

…candidate # Conflicts: # packages/text-annotator-react/src/TextAnnotationPopup/TextAnnotationPopup.tsx
oleksandr-danylchenko · Dec 16, 2024 · ffa9d37 · ffa9d37
2 parents 83bb739 + fbae5c7
commit ffa9d37
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/packages/text-annotator-react/src/TextAnnotationPopup/TextAnnotationPopup.tsx b/packages/text-annotator-react/src/TextAnnotationPopup/TextAnnotationPopup.tsx
@@ -91,13 +91,18 @@ export const TextAnnotationPopup = (props: TextAnnotationPopupProps) => {
   const { getFloatingProps } = useInteractions([dismiss, role]);
 
   useEffect(() => {
-    if (annotation?.id && isAnnotationQuoteIdling) {
-      const bounds = r?.state.store.getAnnotationBounds(annotation.id);
+    if (!r) return;
+
+    const annotationId = annotation?.id;
+    const annotationSelectorsLength = annotation?.target.selector.length;
+
+    if (annotationId && annotationSelectorsLength > 0 && isAnnotationQuoteIdling) {
+      const bounds = r.state.store.getAnnotationBounds(annotation.id);
       setOpen(Boolean(bounds));
     } else {
       setOpen(false);
     }
-  }, [annotation?.id, isAnnotationQuoteIdling, r?.state.store]);
+  }, [annotation?.id, annotation?.target.selector, isAnnotationQuoteIdling, r?.state.store]);
 
   useEffect(() => {
     if (!r) return;