Insert missing trailing commas #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
commented
Feb 10, 2017
| @@ -63,7 +63,7 @@ private[prediction] trait StatsMetricHelper[EI, Q, P, A] { | |||
| evalDataSet.map { | |||
| case (_, qpaRDD) => | |||
| qpaRDD.map { case (q, p, a) => calculate(q, p, a) } | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
| @@ -52,7 +52,7 @@ object BinaryVectorizer { | |||
| .filter(e => properties.contains(e._1)) | |||
| .distinct | |||
| .collect | |||
| .zipWithIndex: _* | |||
| .zipWithIndex: _*, | |||
There was a problem hiding this comment.
I guess this is not necessary, since there won't be more args
There was a problem hiding this comment.
Yeah, when using the vargargs-expansion it doesn't make sense. Good find.
There was a problem hiding this comment.
In the error case, when you've accidentally added or uncommented an additional arg, the error message with the comma might be slightly better.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.