Add js to layout to parse and update filters from URL #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @aivuk ! @shashigharti will have a look and deploy if all good |
shashigharti
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #138
I saw this issue yesterday from @lucpretti and suppose that anyone else would have a hard time implementing that because of the lack of documentation and comments. I create a solution myself yesterday night.
This PR basically sync the filter selected on /projects and /specialist in the url, adding them as query params. It also check if the user loaded the page with an address like
https://network.okfn.org/project/?category=Civic Tech,Design&language=Frenchand in that case do the proper filtering.