CONTRIBUTING: Proposal #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposal to improve the efficiency of development on oh-my-bash project Fixes: ohmybash#89 Fixes: ohmybash#88 Fixes: ohmybash#86 Partially Fixes: ohmybash#85 Partially Fixes: ohmybash#83 Signed-off-by: Jacob Hrbek <[email protected]>
nntoan
previously approved these changes
Aug 14, 2019
|
@nntoan You dismissed it, but commented in a way that seems like approval, please clarify. |
Kreyren
added
P3 - Normal
|
Assigned P2 since this is maintainance improvement issue. |
nntoan
reviewed
Jun 26, 2020
|
|
||
| Oh-My-Bash is a community-driven project. Contribution is welcome, encouraged and appreciated. | ||
| It is also essential for the development of the project. | ||
| Oh-My-Bash is Free and Open Source project under the terms of GNU General Public License v2.0 relying on contributions from third parties. |
There was a problem hiding this comment.
@Kreyren Can you please update to a new contributing proposal to match with our current License?
Thanks.
There was a problem hiding this comment.
Now we are licensing OMB with the MIT license.
akinomyoga
requested changes
Dec 24, 2021
| You can also take a look at the [FAQ](https://github.com/ohmybash/oh-my-bash/wiki/FAQ) | ||
| to be sure your contribution has not already come up. | ||
| ### Quality Assurance (QA) | ||
| All merge requests have to pass spellcheck (https://www.shellcheck.net/) unless stated otherwise. |
There was a problem hiding this comment.
typo spellcheck -> shellcheck
Suggested change
| All merge requests have to pass spellcheck (https://www.shellcheck.net/) unless stated otherwise. | |
| All merge requests have to pass shellcheck (https://www.shellcheck.net/) unless stated otherwise. |
The same typos are also found in other lines.
|
|
||
| Oh-My-Bash is a community-driven project. Contribution is welcome, encouraged and appreciated. | ||
| It is also essential for the development of the project. | ||
| Oh-My-Bash is Free and Open Source project under the terms of GNU General Public License v2.0 relying on contributions from third parties. |
There was a problem hiding this comment.
Now we are licensing OMB with the MIT license.
|
|
||
| ### Getting started | ||
|
|
||
| ## Merge Requests |
There was a problem hiding this comment.
As this is GitHub (but not GitLab or other services), it is more natural to call it Pull Requests. Any thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to improve the efficiency of development on oh-my-bash project
Fixes: #89
Fixes: #88
Fixes: #86
Bug: #85 - Partially fixes
Bug: #83 - Partially fixes
Signed-off-by: Jacob Hrbek [email protected]