Get link destinations via realpath instead of pwd #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyp
reviewed
Oct 23, 2019
functions/marks.fish
Outdated
| set -l output "" | ||
| for mark_name in $mark_list | ||
| cd $MARKPATH/$mark_name | ||
| set -l real_path (pwd) | ||
| set -l real_path (readlink $MARKPATH/$mark_name) |
There was a problem hiding this comment.
I'm not sure how portable readlink is. fish has a built-in realpath function to accomplish the same thing: https://fishshell.com/docs/current/commands.html#realpath
There was a problem hiding this comment.
Thanks for the suggestion. I changed the function to use realpath.
klane
changed the title
|
Any chance to see this PR merge? From what I see, the change is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pwd after moving into the link returns the path to the link, not its destination. This PR uses readlink to get the link destination without having to cd into it.
Fixes: #10