prov/efa: Detect unsolicited write recv support status on both sides #10657
+221
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
force-pushed
the
unsolicited_recv_handshake
branch
2 times, most recently
from
a6a0596 to
f28e40a
Compare
jiaxiyan
approved these changes
Dec 30, 2024
sunkuamzn
reviewed
Dec 30, 2024
prov/efa/src/rdm/efa_rdm_rma.c
Outdated
| "recv feature by setting environment variable FI_EFA_USE_UNSOLICITED_WRITE_RECV=0\n", | ||
| efa_rdm_use_unsolicited_write_recv(), efa_rdm_peer_support_unsolicited_write_recv(txe->peer), | ||
| ep->err_msg); | ||
| return -FI_EINVAL; |
There was a problem hiding this comment.
Wouldn't FI_EOPNOTSUPP be a better error code?
There was a problem hiding this comment.
Thank you, updated.
shijin-aws
force-pushed
the
unsolicited_recv_handshake
branch
2 times, most recently
from
716c5ed to
3d9c9b4
Compare
Currently, when local support unsolicited write recv while the peer doesn't support it, the peer will crash because it expects to get a valid wr_id for IBV_WC_RECV_RDMA_WITH_IMM op code. This peer crash can cause weird error message on sender side's cq when it is still sending data to it. When local doesn't support unsolicited write recv while the peer support it, local will get cq error for the rdma op as "Unexpected status" as well. This patch makes the initiator of rdma write imm detect the unsolicited write recv support status on both sides. If there is inconsistency, the initiator will return error with clear error messages that instruct the mitigation. Signed-off-by: Shi Jin <[email protected]>
shijin-aws
force-pushed
the
unsolicited_recv_handshake
branch
from
3d9c9b4 to
95d7665
Compare
sunkuamzn
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when local support unsolicited write recv while the peer doesn't support it, the peer will crash because it expects to get a valid wr_id for IBV_WC_RECV_RDMA_WITH_IMM op code. This peer crash can cause weird error message on sender side's cq when it is still sending data to it. This patch makes the initiator of rdma write imm detect the unsolicited write recv support status on both sides. If there is inconsistency, the initiator will return error with clear error messages that instruct the mitigation.