Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Remove redundant windows.h #10519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

core: Remove redundant windows.h #10519

wants to merge 1 commit into from

Conversation

weypro
Copy link

@weypro weypro commented Nov 6, 2024

The windows.h header is not necessary for ssize_t definition on Windows platform since BaseTsd.h already provides the required SSIZE_T type definition. Remove this redundant include to reduce compilation dependencies.

@j-xiong
Copy link
Contributor

j-xiong commented Nov 6, 2024

Please break down the long line of the commit message into short lines (<=80 characters).

BTW, the PR can be updated by force pushing the changes. No need to close and create a new PR.

The windows.h header is not necessary for ssize_t definition
on the Windows platform since BaseTsd.h already provides the
required SSIZE_T type definition. Remove this redundant include
to reduce compilation dependencies.

Signed-off-by: wey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants