Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Live 12 support and add tests #20

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Cleanup Live 12 support and add tests #20

merged 6 commits into from
Mar 12, 2024

Commits on Mar 12, 2024

  1. Cleanup: Rename to _parse_events_from_arranger_automation()

    @offlinemark
    offlinemark committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    92d52d4 View commit details
    Browse the repository at this point in the history

  2. Test Live 12 support

    @offlinemark
    offlinemark committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    56ef7fd View commit details
    Browse the repository at this point in the history

  3. Extract _parse_events_from_main_track()

    @offlinemark
    offlinemark committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    dd44697 View commit details
    Browse the repository at this point in the history

  4. Consolidate version checking in one place 

    We could be defensive and raise an error if we detect e.g. Live 13. On
the other hand, we could just try to parse it anyway and see if it
works. I suspect this code might not change much, so there a chance Live
13 could be released and no action is required on our part. Of course it
would be nice to add tests when that happens, but I'd rather not
be so strict and guarantee that we break when L13 comes out.
    @offlinemark
    offlinemark committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    4367c95 View commit details
    Browse the repository at this point in the history

  5. Cleanup: Remove redundant comment and stray line

    @offlinemark
    offlinemark committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    57e8857 View commit details
    Browse the repository at this point in the history

  6. README: Update supported Ableton Live versions

    @offlinemark
    offlinemark committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    899b636 View commit details
    Browse the repository at this point in the history