WIP: Aghs Tooltip on Hero Page #2753
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitttt
commented
Apr 9, 2021
| @@ -38,7 +38,7 @@ const AbilityIcon = styled.img` | |||
| const AbilityManaComsumption = styled.div` | |||
| background: ${constants.colorBlackMuted}; | |||
| color: ${constants.colorMana}; | |||
| border-radius: 2px 0 0 0; | |||
| border-radius: 4px 0 4px 0; | |||
There was a problem hiding this comment.
fixed subtle problem with rounded corners of mana consumption icons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings a new ability slot within the hero page to display the aghanims descriptions (shard and scepter). This data is pulled from dotaconstants using the generated aghs_desc.json file.
Currently does not work, problem with accessing data from aghs_desc.json object structure....because I have no idea what I'm doing. any help is appreciated!