Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] charts: truncate labels by default #4635

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jul 10, 2024

Description

This PR ensures that labels are truncated by default in charts. The truncation can be disabled by passing the truncate option to the chart configuration.

Task: : 3958962

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4596

@robodoo
Copy link
Collaborator

robodoo commented Jul 10, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jul 10, 2024

This PR targets saas-17.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jul 10, 2024

@dhrp-odoo @LucasLefevre ci/runbot failed on this forward-port PR

This commit ensures that labels are truncated by default in charts.
The truncation can be disabled by passing the `truncate` option to
the chart configuration.

Task: 3958962
X-original-commit: e990ea2
@dhrp-odoo dhrp-odoo force-pushed the saas-17.3-17.0-fix-truncate-labels-by-default-dhrp-gDi0-fw branch from 6b5fece to 97d47ad Compare July 10, 2024 09:22
@fw-bot
Copy link
Collaborator Author

fw-bot commented Jul 10, 2024

@dhrp-odoo @LucasLefevre this PR was modified / updated and has become a normal PR. It must be merged directly.

@dhrp-odoo
Copy link
Contributor

@robodoo r+

@robodoo robodoo closed this in 5eb4e88 Jul 10, 2024
@fw-bot fw-bot deleted the saas-17.3-17.0-fix-truncate-labels-by-default-dhrp-gDi0-fw branch July 24, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants