Implement dry run mode #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 20, 2015 11:54
…action to actions classes
…ommand. No dry-run scenario established
…layer in real or dry-run context
| { | ||
| $currentParameters = $this->query('GET', $apiUri); | ||
|
|
||
| if ($currentParameters instanceof Response) { |
There was a problem hiding this comment.
Prefer the opposite to avoid useless imbrication:
if (!$currentParameters instanceof Response) {
return;
}
There was a problem hiding this comment.
of course, will be modified
|
I just tried this option on my laptop. :) Does Rabbit return the correct response code? |
|
I don't have the same issue. |
|
Forget it. |
|
Can you rebase your PR please? :) |
|
Any news about that PR? ping @Domisys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dry run mode compare existing configuration and new one and output computation result with different verbosity modes.