-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds support for Code scanning endpoints #1695
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
8bf582e
to
2ec1b46
Compare
@nickfloyd - not sure the proper way to request a CR from the maintainers on this one to make sure I'm not going off the deep end. Was hoping I followed the structure of other modules + the 2 endpoints added before my change. |
Hety @DanBradbury Thank you for the changes here ❤️. We do our best to try to get things like this reviewed quickly in light of our process. We're a small team of two responsible for about 80 repos so things can get backed up a bit. Apologies for the delay. Great work here, would you mind addressing the linting issues? Then I'd be glad to get this out the door! |
Thank you for the CR! @nickfloyd I've fixed the remaining rubocop issues and pushed it up |
Resolves #1694
Before the change?
After the change?
CodeScanning
module (Skipped the 3 Variant endpoints since it is currently in beta and did not behave according to docs in initial testing)Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!