Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support for Code scanning endpoints #1695

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

DanBradbury
Copy link
Contributor

@DanBradbury DanBradbury commented May 31, 2024

Resolves #1694


Before the change?

  • Support only existed for 2/17 endpoints for Code Scanning

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No
  • No breaking changes since these are net new functions being added to mirror current REST functionality,

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@DanBradbury DanBradbury changed the title Support all Code scanning endpoints Support more Code scanning endpoints May 31, 2024
@DanBradbury
Copy link
Contributor Author

DanBradbury commented Jun 6, 2024

@nickfloyd - not sure the proper way to request a CR from the maintainers on this one to make sure I'm not going off the deep end.

Was hoping I followed the structure of other modules + the 2 endpoints added before my change.

@nickfloyd
Copy link
Contributor

@nickfloyd - not sure the proper way to request a CR from the maintainers on this one to make sure I'm not going off the deep end.

Was hoping I followed the structure of other modules + the 2 endpoints added before my change.

Hety @DanBradbury Thank you for the changes here ❤️. We do our best to try to get things like this reviewed quickly in light of our process. We're a small team of two responsible for about 80 repos so things can get backed up a bit. Apologies for the delay.

Great work here, would you mind addressing the linting issues? Then I'd be glad to get this out the door!

@DanBradbury
Copy link
Contributor Author

Thank you for the CR! @nickfloyd

I've fixed the remaining rubocop issues and pushed it up

@nickfloyd nickfloyd changed the title Support more Code scanning endpoints feat: adds support for Code scanning endpoints Jun 11, 2024
@nickfloyd nickfloyd merged commit dd36a01 into octokit:main Jun 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add Full Code Scanning Support
2 participants