Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language-based object detectors (GLIP, Grounding DINO) support for MMDetection #1003

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

AMauri996
Copy link

Hello ! I've added support of language-based object detectors (GLIP, Grounding DINO) from the latest release of MMdetection which require a text prompt in order to work. I've also included a test and download utils.

Users can provide a custom text prompt using --text argument. If none is provided the class names are used as the text prompt.

Antoine Mauri and others added 3 commits March 7, 2024 13:53
@fcakyon
Copy link
Collaborator

fcakyon commented Apr 8, 2024

Amazing PR @AMauri996 ! 🔥 🚀

Can you also include a quickstart notebook as in other integrations so that users know how to use it?

You can take a look at other notebook files here: https://github.com/obss/sahi/tree/main/demo

@fcakyon fcakyon requested a review from devrimcavusoglu April 8, 2024 15:46
@AMauri996
Copy link
Author

Hello @fcakyon ! Thank you for your review. I've added the demo for GLIP here.

@fcakyon
Copy link
Collaborator

fcakyon commented Apr 22, 2024

@AMauri996 can you fix the styling?

@RobertoPalomares
Copy link

Is there something missing? Happy to jump and help in case it is needed

@AMauri996
Copy link
Author

@fcakyon I fixed the styling, it should be good now

@fcakyon
Copy link
Collaborator

fcakyon commented May 18, 2024

@AMauri996 thanks a lot!

Please fix the nltk based failure in the continuous integration tests @AMauri996 @RobertoPalomares 👍🏻

https://github.com/obss/sahi/pull/1003/checks

@fcakyon fcakyon added the enhancement New feature or request label May 20, 2024
@AMauri996
Copy link
Author

@fcakyon I fixed the nltk error in the tests

@fcakyon
Copy link
Collaborator

fcakyon commented Jun 2, 2024

Thanks for the fast fix, @AMauri996. Can you please update demo notebook using the latest up-to-date mmdetection notebook available in the sahi repo? Then we would be glad to merge your contribution!

@AMauri996
Copy link
Author

Hello @fcakyon ! I've solved the merge conflict caused by the mmdetection notebook

@fcakyon
Copy link
Collaborator

fcakyon commented Aug 5, 2024

Hello @fcakyon ! I've solved the merge conflict caused by the mmdetection notebook

Thanks for your efforts @AMauri996 !

Why do you think the mmdet tests are failing? 🤔 https://github.com/obss/sahi/actions/runs/10006492987/job/28194626143?pr=1003#step:19:1340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants