Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlc-video plugin: Add option to suppress stop and restart stream on playlist update #10918

Closed

Conversation

L13w
Copy link

@L13w L13w commented Jun 25, 2024

Currently, the stream is stopped whenever you update a video playlist in vlc-video plugin properties. This enhancement adds an option to disable starting and stopping the stream so that the current video will continue and play the next video in the updated playlist when the current video finishes.

Description

Currently, when you update a video playlist in the vlc-video plugins properties page and commit the changes, the plugin stops the stream and restarts the playlist from the beginning. This option allows the user to suppress the stop and restart so that the updated stream and playlist continues playing.

The current stream will continue playing and the video in the next index position in the playlist will be played next.
restart stream

Motivation and Context

Many people have said that the current behavior is not expected, and they wish that the vlc-video plugin did not behave this way. Here is an example: https://obsproject.com/forum/threads/media-playlist-source.168774/#post-648347

How Has This Been Tested?

I tested it on Windows 11.

Created a playlist and updated it on the fly while the stream was playing. When I unchecked "Restart Stream" and rearranged videos in playlists, the vlc-video plugin played the expected videos based on the updated playlists. When the "Restart Stream" checkbox is checked, the stream stops and starts at the beginning of the updated playlist, which is the expected current functionality.

Types of changes

Tweak (non-breaking change to improve existing functionality)

When the user unchecks the Restart Stream checkbox, the plugin skips the "Stop and Starts a new stream with the updated playlist", which continues playing the current video and continues with the next video in the updated playlist. This checkbox is set to True by default, which matches the current plugin functionality. The user has to take the action of unchecking the box to get the enhanced functionality.

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation. (I was not able to find any documentation to update).

L13w added 5 commits June 24, 2024 16:50
Currently, the stream is stopped whenever you update a video playlist in vlc video plugin properties. This update adds an option to disable starting and stopping the stream so that the current video will continue and play the next video in the updated playlist when the current video finishes.
Currently, the stream is stopped whenever you update a video playlist in vlc video plugin properties. This update adds an option to disable starting and stopping the stream so that the current video will continue and play the next video in the updated playlist when the current video finishes.
@L13w L13w closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant